Re: CVS commit in ZendEngine2/zend_execute.c

php.internals

David Brown

23 years ago
> zend_execute.c, 1.468 (sterling) > Sat May 31 14:31:28 2003 (5 hours, 35 minutes ago) > revert the function call caching patch until a new solution is decided > upon.
Hi: Is this being reverted due to a reported crash? If not, I'm currently seeing several with the patch applied (which go away with the recent revert). Valgrind says: Conditional jump or move depends on uninitialised value(s) at 0x817367D: zend_init_fcall_by_name_handler (zend_execute.c:2565) by 0x816EC54: execute (zend_execute.c:1247) by 0x8173B14: zend_do_fcall_common_helper (zend_execute.c:2654) by 0x8173F6A: zend_do_fcall_by_name_handler (zend_execute.c:2725) I can supply backtraces and try to derive a test case if this is a new crash. If not, I'm relieved that I wasn't debugging alone - I've had a '0 &&' in the reverted if() for the past 12 hours. :) Thanks a lot, - Dave dave@codewhore.org

(Marcus Börger)

23 years ago
At 02:04 01.06.2003, David Brown wrote:
> > zend_execute.c, 1.468 (sterling) > > Sat May 31 14:31:28 2003 (5 hours, 35 minutes ago) > > revert the function call caching patch until a new solution is decided > > upon. > >Hi: > >Is this being reverted due to a reported crash? If not, I'm currently >seeing several with the patch applied (which go away with the recent >revert). Valgrind says: > > Conditional jump or move depends on uninitialised value(s) > at 0x817367D: zend_init_fcall_by_name_handler (zend_execute.c:2565) > by 0x816EC54: execute (zend_execute.c:1247) > by 0x8173B14: zend_do_fcall_common_helper (zend_execute.c:2654) > by 0x8173F6A: zend_do_fcall_by_name_handler (zend_execute.c:2725) > >I can supply backtraces and try to derive a test case if this is a new >crash. If not, I'm relieved that I wasn't debugging alone - I've had a >'0 &&' in the reverted if() for the past 12 hours. :)
Yes David, in ZTS mode it causes much problems, i found them some hours ago. But the main reason for revert is that the patch was done in the wrong way. Currently we are trying to figure out a new way since the performance boost is very good. regards marcus

David Brown

23 years ago
On Sun, Jun 01, 2003 at 02:34:41AM +0200, Marcus B?rger wrote: | Yes David, | | in ZTS mode it causes much problems, i found them some hours ago. But | the main reason for revert is that the patch was done in the wrong | way. Currently we are trying to figure out a new way since the | performance boost is very good. Hi Marcus, The crash I was seeing was under the CLI sapi, without ZTS enabled. If this is unexpected, I can try for a test case. Otherwise, if you're pretty sure the patch had more wrong with it than there was right, I'll hold off. :) The codebase I was seeing the crash in is large and reasonably complex - I was just checking to make sure that the patch was indeed causing the problem, not just making it visible. Anyway. Much thanks. :) - Dave