Everything

php

[PATCH] Some small optimizations

php.internals

Matt W

19 years ago

Hi,

Here are patches to use Brian Shire's optimizations (applied by Ilia to 5.2 the other day) in a couple more places, and for HEAD.  In Unicode mode, concat_function() is up to 20%+ faster!  (Probably because zend_make_unicode_zval() calls TSRMLS_FETCH(); so not so much with non-ZTS I guess.)

Also removed a few strlen() calls that I noticed when looking at is_numeric_string's usage awhile ago. :-)

http://realplain.com/php/misc_optimizations.diff
http://realplain.com/php/misc_optimizations_5_2.diff

Matt

Ilia A.

19 years ago

Matt,

The ext/* patches were applied to 5.2, I'll commit the Zend/ ones
once we have an agreement on the previous patch.

On 13-Dec-06, at 8:22 AM, Matt Wilmas wrote:

> Hi,
>
> Here are patches to use Brian Shire's optimizations (applied by
> Ilia to 5.2 the other day) in a couple more places, and for HEAD.
> In Unicode mode, concat_function() is up to 20%+ faster!  (Probably
> because zend_make_unicode_zval() calls TSRMLS_FETCH(); so not so
> much with non-ZTS I guess.)
>
> Also removed a few strlen() calls that I noticed when looking at
> is_numeric_string's usage awhile ago. :-)
>
> http://realplain.com/php/misc_optimizations.diff
> http://realplain.com/php/misc_optimizations_5_2.diff
>
>
> Matt

Ilia Alshanetsky

Andrei Zmievski

19 years ago

Which previous patch? From Matt?

-Andrei

On Dec 13, 2006, at 7:33 AM, Ilia Alshanetsky wrote:

Ilia A.

19 years ago

On 13-Dec-06, at 11:54 AM, Andrei Zmievski wrote:

> Which previous patch? From Matt?

The one for is_numeric_string()

Ilia Alshanetsky