[PATCH] OpenSSL CRL Support

php.internals

Moritz Bechler

19 years ago
Hi, I already asked for comments on inclusion of OpenSSL CRL support in ext/openssl some time ago (I had a independend extension at this point). As I continued working on it I realized that making this an independend extension makes me to reinvent/reimplement the wheel and makes it impossible to have ext/openssl and the CRL support to integrate nicely, so I wrote a patch to include it in ext/openssl. In fact, having Marc Delling's PKCS#12 patch and mine applied makes it possible to write basic but real PKI-CA applications in PHP, so I think it would be nice to have this. I know that there are not that many people who need this but I think this is true for nearly the whole openssl extension except for the stream wrapper. (maybe we should consider splitting it up?) You find a patch (hopefully I got your conding standards right ;)) attached, but I should take careful review because this actually is my first work on PHP extensions and I'm also not used to writing C code. I can/will provide a test (what kind of tests should I supply?) and documentation when needed. Moritz Bechler

Pierre Joye

19 years ago
Hello Moritz, On 1/6/07, Moritz Bechler <mbechler@eenterphace.org> wrote:
> Hi, > > I already asked for comments on inclusion of OpenSSL CRL support in > ext/openssl some time ago (I had a independend extension at this point).
Do you have a bug id please? If not please open one.
> As I continued working on it I realized that making this an independend > extension makes me to reinvent/reimplement the wheel and makes it > impossible to have ext/openssl and the CRL support to integrate nicely, > so I wrote a patch to include it in ext/openssl. > > In fact, having Marc Delling's PKCS#12 patch and mine applied makes it > possible to write basic but real PKI-CA applications in PHP, so I think > it would be nice to have this.
This patch is in the queue. There is a bug report about it. I will add the pending patches to the next development branch for 5.x and HEAD once 5.2.1 is out.
> I know that there are not that many people who need this but I think > this is true for nearly the whole openssl extension except for the > stream wrapper. (maybe we should consider splitting it up?)
Even if not many people needs openssl functions, the needs are here and it is a pain when a feature is missing.
> You find a patch (hopefully I got your conding standards right ;)) > attached, but I should take careful review because this actually is my > first work on PHP extensions and I'm also not used to writing C code. > I can/will provide a test (what kind of tests should I supply?) and > documentation when needed.
Thanks for patch! Can you put it in a bug report so it will not get lost? And you will be informed as soon as it is committed. Regards, --Pierre

Moritz Bechler

19 years ago
Hi Pierre,
> Hello Moritz, > > On 1/6/07, Moritz Bechler <mbechler@eenterphace.org> wrote: >> Hi, >> >> I already asked for comments on inclusion of OpenSSL CRL support in >> ext/openssl some time ago (I had a independend extension at this point). > > Do you have a bug id please? If not please open one.
Open a feature request #40046. Hope that is sufficient. Moritz Bechler

Pierre Joye

19 years ago
On 1/6/07, Moritz Bechler <mbechler@eenterphace.org> wrote:
> Hi Pierre, > > Hello Moritz, > > > > On 1/6/07, Moritz Bechler <mbechler@eenterphace.org> wrote: > >> Hi, > >> > >> I already asked for comments on inclusion of OpenSSL CRL support in > >> ext/openssl some time ago (I had a independend extension at this point). > > > > Do you have a bug id please? If not please open one. > > Open a feature request #40046. Hope that is sufficient.
It is, I added a link to your patch (the most important part of this thread ;) --Pierre