Everything

php

Engine selection on Win32

php.internals

Sascha Schumann

23 years ago

Here is a patch which automates the engine selection for VC++.

http://www.php.net/~sas/win32-engineselect.diff

This has been successfully tested with VC++ 6.0.  Together with
the already committed patch for Unix, this completes the work
on making CVS handling version-agnostic and more transparent
to all PHP developers.

- Sascha

Sebastian Bergmann

23 years ago

Sascha Schumann wrote:

> Here is a patch which automates the engine selection for VC++.

Works here, too.

But is this really necessary? I fail to see the point of having to
check out both versions of the Zend Engine twice when doing

cvs co -r HEAD php-src

and

cvs co -r PHP_4_3 php-src

for instance.

Is there any technical problem, that I don't see, with the way we
handled this before (havin php4 and php5 aliased that select the
correct {Zend|ZendEngine2} CVS module)?

--
Sebastian Bergmann
http://sebastian-bergmann.de/                 http://phpOpenTracker.de/

http://www.professionelle-softwareentwicklung-mit-php5.de/

Zeev Suraski

23 years ago

At 23:58 25/06/2003, Sebastian Bergmann wrote:

>Sascha Schumann wrote:
> > Here is a patch which automates the engine selection for VC++.
>
>   Works here, too.
>
>   But is this really necessary? I fail to see the point of having to
>   check out both versions of the Zend Engine twice when doing
>
>     cvs co -r HEAD php-src
>
>   and
>
>     cvs co -r PHP_4_3 php-src
>
>   for instance.
>
>   Is there any technical problem, that I don't see, with the way we
>   handled this before (havin php4 and php5 aliased that select the
>   correct {Zend|ZendEngine2} CVS module)?

I second that.  There's no reason not to keep the php5 alias, and no reason
not to tell people that the way to checkout php4 is cvs -r PHP_$ php4.
The Win32 diff may work, but it certainly is ugly.

Zeev

Jani Taskinen

23 years ago

On Thu, 26 Jun 2003, Zeev Suraski wrote:

>At 23:58 25/06/2003, Sebastian Bergmann wrote:
>>Sascha Schumann wrote:
>> > Here is a patch which automates the engine selection for VC++.
>>
>>   Works here, too.
>>
>>   But is this really necessary? I fail to see the point of having to
>>   check out both versions of the Zend Engine twice when doing
>>
>>     cvs co -r HEAD php-src
>>
>>   and
>>
>>     cvs co -r PHP_4_3 php-src
>>
>>   for instance.
>>
>>   Is there any technical problem, that I don't see, with the way we
>>   handled this before (havin php4 and php5 aliased that select the
>>   correct {Zend|ZendEngine2} CVS module)?
>
>I second that.  There's no reason not to keep the php5 alias, and no reason
>not to tell people that the way to checkout php4 is cvs -r PHP_$ php4.
>The Win32 diff may work, but it certainly is ugly.

Checkout of php-src should only give you php-src, not Zend. :)
There's nothing wrong with the php4/php5 aliases, that worked
just fine, now this shit in there now gives you 2 zend-directories..
Ridiculous.

--Jani

Sascha Schumann

23 years ago

>     Checkout of php-src should only give you php-src, not Zend. :)
>     There's nothing wrong with the php4/php5 aliases, that worked
>     just fine, now this shit in there now gives you 2 zend-directories..
>     Ridiculous.

I agree that it is ridiculous that we have two zend
directories.  It really should be one.

The problem is that merging the two CVS histories is pretty
ugly and not something which can be done in one day.

Contrary to your belief, there are a lot of issues with the
php4/php5 aliases as pointed out in my earlier email.

- Sascha