Bug #20836

php.internals

Timm Friebe

23 years ago
http://bugs.php.net/bug.php?id=20836 Can someone give me sufficient karma to commit the missing documentation or simply apply the patch? - Timm

Sander Roobol

23 years ago
If you supply a unified diff, I'll commit it. Thanks, Sander On Sat, Mar 22, 2003 at 04:36:13PM +0100, Timm Friebe wrote:

Timm Friebe

23 years ago
On Sun, 2003-03-23 at 11:48, Sander Roobol wrote:
> If you supply a unified diff, I'll commit it.
OK. Attached is a unified diff - the three new files which need to be added can be found at: http://sitten-polizei.de/php/sybase-fetch-assoc.xml http://sitten-polizei.de/php/sybase-unbuffered-query.xml http://sitten-polizei.de/php/sybase-set-message-handler.xml HTH: Timm

Sander Roobol

23 years ago
On Sun, Mar 23, 2003 at 03:37:03PM +0100, Timm Friebe wrote:
> On Sun, 2003-03-23 at 11:48, Sander Roobol wrote: > > If you supply a unified diff, I'll commit it. > > OK. Attached is a unified diff - the three new files which need to be > added can be found at:
I've applied your patch, but I didn't add those three files since they already exist. Your files seem to have some improvements, so I suggest you merge your changes into the current version. Please do so and send a new unified diff. Thanks, Sander

Timm Friebe

23 years ago
On Sun, 2003-03-23 at 18:26, Sander Roobol wrote:
> On Sun, Mar 23, 2003 at 03:37:03PM +0100, Timm Friebe wrote: > > On Sun, 2003-03-23 at 11:48, Sander Roobol wrote: > > > If you supply a unified diff, I'll commit it. > > > > OK. Attached is a unified diff - the three new files which need to be > > added can be found at: > > I've applied your patch, but I didn't add those three files since they > already exist. Your files seem to have some improvements, so I suggest > you merge your changes into the current version. Please do so and send a > new unified diff.
After looking into it: * sybase-fetch-assoc.xml is OK the way it is * Added some examples to sybase-set-message-handler.xml * Corrected the statement "will fail" to "will produce a warning" and added an example to sybase-unbuffered-query.xml Unified diff is attached. HTH: Timm

Sander Roobol

23 years ago
On Wed, Mar 26, 2003 at 11:07:15AM +0100, Timm Friebe wrote:
> After looking into it: > * sybase-fetch-assoc.xml is OK the way it is > * Added some examples to sybase-set-message-handler.xml > * Corrected the statement "will fail" to "will produce a warning" > and added an example to sybase-unbuffered-query.xml > > Unified diff is attached.
Thanks! Applied. Sander