Everything
php
Learn Community Releases The PHP Project
Home » Project » Newsgroups » php.internals » Re: pfpro issuing E_ERROR when E_WARNING would be more appropriate »

Re: pfpro issuing E_ERROR when E_WARNING would be more appropriate

php.internals

David

23 years ago
These errors are thrown when the user is passing illegal variable types, please explain why you think they should be warnings. Even silently converting them to other types would make no sense in these cases. David (marc doesn't show e-mail addresses so I can't cc the submitter) Sara wrote:
> ext/pfpro/pfpro.c has several php_error_docref() calls (particularly in > pfpro_process) which issue E_ERROR (Fatal Errors/Non-recoverable) in > situations where an E_WARNING would seem more appropriate (as it would
allow
> the calling script to recover and continue. > > Is there a particular reason a fatal error would be thrown in this case? > > -Sara
-- |> /+\ \| | |> David Croft Infotrek

Derick Rethans

23 years ago
On Mon, 14 Jul 2003, David wrote:
> > These errors are thrown when the user is passing illegal variable types, > please explain why you think they should be warnings. Even silently > converting them to other types would make no sense in these cases.
It still shouldn't throw a fatal error. E_ERROR is only meant for critical errors that will destabalize the Engine, in all other cases E_WARNING should be used, which is almost always the case in extensions. regards, Derick
-- "Interpreting what the GPL actually means is a job best left to those that read the future by examining animal entrails." ------------------------------------------------------------------------- Derick Rethans http://derickrethans.nl/ International PHP Magazine http://php-mag.net/ -------------------------------------------------------------------------